Shekharrajak commented on code in PR #22357:
URL: https://github.com/apache/kafka/pull/22357#discussion_r3293970654
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -455,6 +469,41 @@ public synchronized TransactionalRequestResult
sendOffsetsToTransaction(final Ma
return handler.result;
}
+ public synchronized TransactionalRequestResult
sendShareAcknowledgementsToTransaction(
+ final Map<TopicIdPartition, List<AcknowledgementBatch>>
acknowledgements,
+ final ShareGroupMetadata groupMetadata) {
+ ensureTransactional();
+
throwIfPendingState(TransactionOperation.SEND_SHARE_ACKNOWLEDGEMENTS_TO_TRANSACTION);
+ maybeFailWithError();
+
+ if (currentState != State.IN_TRANSACTION) {
+ throw new IllegalStateException("Cannot send share
acknowledgements if a transaction is not in progress " +
+ "(currentState= " + currentState + ")");
+ }
+
+ TxnRequestHandler handler;
Review Comment:
Same implementation as sendOffsetsToTransaction()
transactionManager.sendOffsetsToTransaction(offsets, groupMetadata);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
