Shekharrajak commented on code in PR #22357:
URL: https://github.com/apache/kafka/pull/22357#discussion_r3294048373
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -353,6 +354,36 @@ public CompletableFuture<Map<TopicIdPartition,
ShareAcknowledgeResponseData.Part
return mapAcknowledgementFutures(futures,
Optional.of(failedShareAcknowledgeMetricsHandler()));
}
+ public CompletableFuture<Map<TopicIdPartition,
ShareAcknowledgeResponseData.PartitionData>> acknowledgeTransactional(
+ String memberId,
+ String groupId,
+ long producerId,
+ short producerEpoch,
+ Map<TopicIdPartition, List<ShareAcknowledgementBatch>>
acknowledgeTopics
+ ) {
+ log.trace("Txn acknowledge request for topicIdPartitions: {} groupId:
{} producerId={}",
+ acknowledgeTopics.keySet(), groupId, producerId);
+ Map<TopicIdPartition, CompletableFuture<Throwable>> futures = new
HashMap<>();
+ acknowledgeTopics.forEach((topicIdPartition,
acknowledgePartitionBatches) -> {
+ SharePartitionKey sharePartitionKey = sharePartitionKey(groupId,
topicIdPartition);
+ SharePartition sharePartition =
partitionCache.get(sharePartitionKey);
Review Comment:
sharePartition.stageTxnAcknowledge(memberId, producerId, producerEpoch,
acknowledgePartitionBatches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
