AndrewJSchofield commented on PR #22357: URL: https://github.com/apache/kafka/pull/22357#issuecomment-4529062397
Thanks for the PR. Personally, I would prefer if there was no PR for such a complicated KIP until it has successfully passed a vote. Without serious review by committers knowledgeable in the areas of share groups and transactions, the KIP would not yet be able to pass a vote. It will need +3 binding votes. There are many details which need to be agreed by the committers before we are there. For example, we will need to have a new `transaction.version` and new `share.version` to ensure that we correctly police these schema changes to the information on the internal metadata topics, and only enable the feature once all brokers in the cluster are ready. We would typically break down the code into many PRs so that the chunks are reviewable with reasonable effort. For example, I would do the feature changes first, then the JSON RPC schemas, and then gradually introduce the actual logic. I suggest KIP-1191 and https://issues.apache.org/jira/browse/KAFKA-19469 as a good example of breaking the code down and introducing it progressively (that's one I'm actively reviewing for AK 4.4). Finally, we would not accept a KIP like this directly into Apache Kafka as a GA feature without some kind of Early Access or Preview release, so the feature bump also allows us to pace its enablement with the successful completion of an extended period of system testing. My suggestion would be to close the PR, concentrate on fleshing out the KIP and building alignment with committers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
