smjn commented on PR #22389: URL: https://github.com/apache/kafka/pull/22389#issuecomment-4561576617
Thanks for the PR - overall looks good but some observations: The interfaces and classes though directly usable in share group based code - do not have any dependency with share related client or server artifacts. Wouldn't it be better to move them to neutral packages (not including `.share`) so that that can we adopted in other components as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
