apoorvmittal10 commented on PR #22389: URL: https://github.com/apache/kafka/pull/22389#issuecomment-4561672763
> Wouldn't it be better to move them to neutral packages (not including `.share`) so that their general nature could be highlighted? Yeah, I thought about it and moved them to share package as of now because the usage is primarily there i.e. DelayedShareFetch, SharePartition, SharePartitionManager and the DLQ classes. I was of the opinion that if we do see more usage outside share groups then we should move the classes outside share package in future but not right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
