apoorvmittal10 commented on code in PR #22372:
URL: https://github.com/apache/kafka/pull/22372#discussion_r3320898085
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -330,15 +329,16 @@ enum SharePartitionState {
private long fetchLockIdleDurationMs;
/**
- * Reference to the dlq manager implementation.
+ * Supplier to toggle DLQ support.
*/
- private final ShareGroupDLQManager shareGroupDLQ = new
NoOpShareGroupDLQManager();
+ private final Supplier<Boolean> shareGroupDlqEnableSupplier;
/**
- * Supplier to toggle dlq support.
+ * Reference to the DLQ manager implementation.
*/
- private final Supplier<Boolean> shareGroupDlqEnableSupplier;
+ private final ShareGroupDLQManager shareGroupDLQManager;
+ @SuppressWarnings("ParameterNumber")
Review Comment:
I have added same in
https://github.com/apache/kafka/pull/22407/changes#diff-1caaa9743f4aa4a5d156f2b3cc72b86079f5c17b944d5dfdda2d0d39e7f14816R44.
So either of those should be required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
