smjn commented on PR #22372: URL: https://github.com/apache/kafka/pull/22372#issuecomment-4571332000
> Overall looks good, 1 question though: the ShareGroupDLQManager is instatiated regardless of whether DLQ is enabled or not, as supplier is provided, hence do you think we can delay instatiation of ShareGroupDLQManager only when the share version is correctly toggled? Hi, share.version=2 should be defaulted in the next release so above change will be transient as DLQ manager will always be needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
