nileshkumar3 commented on code in PR #22356:
URL: https://github.com/apache/kafka/pull/22356#discussion_r3321939529
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1547,15 +1547,25 @@ private static boolean
areOwnedTasksContainedInAssignedTasksWithEpochs(
* Checks whether the consumer group can accept a new member or not based
on the
* max group size defined.
*
- * @param group The consumer group.
- * @param memberId The member id.
+ * @param group The consumer group.
+ * @param memberId The member id.
+ * @param instanceId The instance id.
*
* @throws GroupMaxSizeReachedException if the maximum capacity has been
reached.
Review Comment:
can we modify this adding the static-member exemption
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1547,15 +1547,25 @@ private static boolean
areOwnedTasksContainedInAssignedTasksWithEpochs(
* Checks whether the consumer group can accept a new member or not based
on the
* max group size defined.
Review Comment:
some change required here per the new change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
