chickenchickenlove commented on code in PR #22356:
URL: https://github.com/apache/kafka/pull/22356#discussion_r3328060359
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -1547,15 +1547,25 @@ private static boolean
areOwnedTasksContainedInAssignedTasksWithEpochs(
* Checks whether the consumer group can accept a new member or not based
on the
* max group size defined.
*
- * @param group The consumer group.
- * @param memberId The member id.
+ * @param group The consumer group.
+ * @param memberId The member id.
+ * @param instanceId The instance id.
*
* @throws GroupMaxSizeReachedException if the maximum capacity has been
reached.
Review Comment:
I think this is better documented as an inline comment near the branch
rather than in the method JavaDoc. The method-level comment describes the
general max-size validation, while the static-member replacement case is a
local implementation detail of the `hasStaticMember(instanceId)` branch.
When a static member temporarily leaves and later rejoins, it is effectively
the same member from the static membership perspective, so I don't think it
needs to be called out as a separate exception in the method JavaDoc.
What do others think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
