chia7712 commented on code in PR #20707:
URL: https://github.com/apache/kafka/pull/20707#discussion_r3325487810
##########
metadata/src/main/java/org/apache/kafka/metadata/storage/Formatter.java:
##########
@@ -432,11 +449,10 @@ void doFormat(BootstrapMetadata bootstrapMetadata) throws
Exception {
directoryTypes.get(writeLogDir).description(), writeLogDir,
MetadataVersion.FEATURE_NAME, releaseVersion);
Files.createDirectories(Paths.get(writeLogDir));
- BootstrapDirectory bootstrapDirectory = new
BootstrapDirectory(writeLogDir);
- bootstrapDirectory.writeBinaryFile(bootstrapMetadata);
- if
(directoryTypes.get(writeLogDir).isDynamicMetadataDirectory()) {
Review Comment:
Should we keep the `isDynamicMetadataDirectory()` condition here? I noticed
that the E2E tests fail in combined mode with multiple log directories because
the pure data folders end up containing the unexpected `__cluster_metadata-0`
directory
https://github.com/apache/kafka/blob/6bfa19475d27808de524ac34d321bac387bd760a/core/src/main/scala/kafka/server/KafkaRaftServer.scala#L150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
