chia7712 commented on code in PR #20707:
URL: https://github.com/apache/kafka/pull/20707#discussion_r3329092131
##########
core/src/test/scala/unit/kafka/server/KafkaRaftServerTest.scala:
##########
@@ -109,8 +110,13 @@ class KafkaRaftServerTest {
}
private def writeBootstrapMetadata(logDir: File, metadataVersion:
MetadataVersion): Unit = {
- val bootstrapDirectory = new BootstrapDirectory(logDir.toString)
-
bootstrapDirectory.writeBinaryFile(BootstrapMetadata.fromVersion(metadataVersion,
"test"))
Review Comment:
Regarding our discussion about running an older Kafka broker using a
directory formatted by a newer kafka-storage tool: I think it's worth adding
some upgrade notes to prevent user confusion.
For example, we could document this in upgrade.md and enhance the
StorageTool help text for `--release-version` with something like:
'Note: The formatted directories are not forward-compatible. You must run a
Kafka broker that is the same or newer than the kafka-storage tool used to
format the directory, even if you specify an older --release-version.'
@mannoopj @jsancio @kevin-wu24 WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
