jingjia88 commented on code in PR #21416:
URL: https://github.com/apache/kafka/pull/21416#discussion_r3330562937
##########
server-common/src/main/java/org/apache/kafka/server/config/QuotaConfig.java:
##########
@@ -74,16 +74,16 @@ public class QuotaConfig {
public static final String LEADER_REPLICATION_THROTTLED_RATE_CONFIG =
"leader.replication.throttled.rate";
public static final String LEADER_REPLICATION_THROTTLED_RATE_DOC = "A long
representing the upper bound (bytes/sec) on replication traffic for leaders
enumerated in the " +
- String.format("property %s (for each topic). This property can be
only set dynamically. It is suggested that the ",
LEADER_REPLICATION_THROTTLED_REPLICAS_CONFIG) +
+ String.format("property %s (for each topic). This property can be
only set dynamically and static configurations in server.properties are
ignored. It is suggested that the ",
LEADER_REPLICATION_THROTTLED_REPLICAS_CONFIG) +
Review Comment:
good idea, updated to log a WARN at broker startup when any of these three
configs is present in server.properties, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
