chia7712 commented on code in PR #21416:
URL: https://github.com/apache/kafka/pull/21416#discussion_r3369674499
##########
server-common/src/main/java/org/apache/kafka/server/config/QuotaConfig.java:
##########
@@ -74,18 +74,23 @@ public class QuotaConfig {
public static final String LEADER_REPLICATION_THROTTLED_RATE_CONFIG =
"leader.replication.throttled.rate";
public static final String LEADER_REPLICATION_THROTTLED_RATE_DOC = "A long
representing the upper bound (bytes/sec) on replication traffic for leaders
enumerated in the " +
- String.format("property %s (for each topic). This property can be
only set dynamically. It is suggested that the ",
LEADER_REPLICATION_THROTTLED_REPLICAS_CONFIG) +
+ String.format("property %s (for each topic). This property can be
only set dynamically and static configurations in server.properties are
ignored. It is suggested that the ",
LEADER_REPLICATION_THROTTLED_REPLICAS_CONFIG) +
"limit be kept above 1MB/s for accurate behaviour.";
public static final String FOLLOWER_REPLICATION_THROTTLED_RATE_CONFIG =
"follower.replication.throttled.rate";
public static final String FOLLOWER_REPLICATION_THROTTLED_RATE_DOC = "A
long representing the upper bound (bytes/sec) on replication traffic for
followers enumerated in the " +
- String.format("property %s (for each topic). This property can be
only set dynamically. It is suggested that the ",
FOLLOWER_REPLICATION_THROTTLED_REPLICAS_CONFIG) +
+ String.format("property %s (for each topic). This property can be
only set dynamically and static configurations in server.properties are
ignored. It is suggested that the ",
FOLLOWER_REPLICATION_THROTTLED_REPLICAS_CONFIG) +
"limit be kept above 1MB/s for accurate behaviour.";
public static final String
REPLICA_ALTER_LOG_DIRS_IO_MAX_BYTES_PER_SECOND_CONFIG =
"replica.alter.log.dirs.io.max.bytes.per.second";
public static final String
REPLICA_ALTER_LOG_DIRS_IO_MAX_BYTES_PER_SECOND_DOC = "A long representing the
upper bound (bytes/sec) on disk IO used for moving replica between log
directories on the same broker. " +
- "This property can be only set dynamically. It is suggested that
the limit be kept above 1MB/s for accurate behaviour.";
+ "This property can be only set dynamically and static
configurations in server.properties are ignored. It is suggested that the limit
be kept above 1MB/s for accurate behaviour.";
Review Comment:
`server.properties` is not always correct. Would you mind using `static
configuration file` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
