aliehsaeedii commented on code in PR #22397:
URL: https://github.com/apache/kafka/pull/22397#discussion_r3340097036
##########
clients/src/main/resources/common/message/StreamsGroupDescribeResponse.json:
##########
@@ -106,7 +107,12 @@
"about": "True for classic members that have not been upgraded
yet." }
]},
{ "name": "AuthorizedOperations", "type": "int32", "versions": "0+",
"default": "-2147483648",
- "about": "32-bit bitfield to represent authorized operations for
this group." }
+ "about": "32-bit bitfield to represent authorized operations for
this group." },
+ { "name": "TopologyDescription", "type": "TopologyDescription",
"versions": "1+",
+ "nullableVersions": "1+", "default": "null",
+ "about": "The full topology description for this group. Non-null if
and only if TopologyDescriptionStatus is AVAILABLE (3); null otherwise." },
+ { "name": "TopologyDescriptionStatus", "type": "int8", "versions":
"1+", "default": "0",
Review Comment:
Do you agree with this suggestion?
The `int8` status values (0–3) are documented only in this prose `about`,
and since the message generator emits no enum for an `int8`, every Java call
site uses a bare cast — `setTopologyDescriptionStatus((byte) 2)` in
`StreamsGroupDescribeRequest`, `(byte) 1/3` in the tests. Worth defining shared
named constants for these status values so the meanings don't drift across call
sites.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
