aliehsaeedii commented on code in PR #22397: URL: https://github.com/apache/kafka/pull/22397#discussion_r3344798916
########## clients/src/main/resources/common/message/StreamsGroupTopologyDescriptionUpdateRequest.json: ########## @@ -0,0 +1,71 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +{ + "apiKey": 93, + "type": "request", + "listeners": ["broker"], + "name": "StreamsGroupTopologyDescriptionUpdateRequest", + // The broker handler is not yet implemented (deferred to a later sub-task of KIP-1331), + // so the latest version is marked unstable to suppress ApiVersions advertisement. + "latestVersionUnstable": true, Review Comment: Good catch on Heartbeat v1 and Describe v1 — those bumps are dead weight until the topology-description manager lands, and I'll mark them latestVersionUnstable: true and add a follow-up JIRA to flip them stable before release. DeleteGroups v3 I'd prefer to keep stable: ErrorMessage is a general-purpose enhancement that any error path can use, not specific to topology-description. FYI: marking the two Streams bumps unstable broke Builder.build() defaults in tests when I tried it on the new RPC — I'll need to use explicit-version build(short) calls. ########## clients/src/main/resources/common/message/StreamsGroupTopologyDescriptionUpdateRequest.json: ########## @@ -0,0 +1,71 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +{ + "apiKey": 93, + "type": "request", + "listeners": ["broker"], + "name": "StreamsGroupTopologyDescriptionUpdateRequest", + // The broker handler is not yet implemented (deferred to a later sub-task of KIP-1331), + // so the latest version is marked unstable to suppress ApiVersions advertisement. + "latestVersionUnstable": true, Review Comment: https://issues.apache.org/jira/browse/KAFKA-20655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
