alanlau28 opened a new pull request, #22476:
URL: https://github.com/apache/kafka/pull/22476

   Improves the documentation for `segment.bytes`, `segment.ms`, and 
`max.compaction.lag.ms` with respect to active segment rolling.
   
   The active segment is never compacted; a record becomes eligible for 
compaction only after active segment rolling moves it out of the active 
segment. The docs did not make this clear, nor did they explain that for 
compacted topics `max.compaction.lag.ms` lowers the effective time-based roll 
deadline to `min(segment.ms, max.compaction.lag.ms)`.
   
   Changes:
   - `TopicConfig` doc strings: each of the three configs now states its role 
in active segment rolling (size / time / compaction lag). 
`max.compaction.lag.ms` additionally separates the two things it governs — when 
the active segment is rolled vs. when the rolled records become eligible for 
compaction — and links to the log compaction section.
   - `docs/design/design.md`: the Log Compaction section's 
`max.compaction.lag.ms` paragraph now explains both steps, noting the active 
segment is never compacted and that the roll is evaluated on append.
   
   Documentation only; no behavior, default, constraint, API, or metric change 
(no KIP required).
   
   Testing: `./gradlew clients:compileJava clients:checkstyleMain` passes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to