smjn commented on code in PR #22479:
URL: https://github.com/apache/kafka/pull/22479#discussion_r3366977909
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -777,7 +777,9 @@ class BrokerServer(
new ShareCoordinatorMetadataCacheHelperImpl(metadataCache, key =>
shareCoordinator.partitionFor(key), config.interBrokerListenerName,
groupConfigManager),
Time.SYSTEM,
shareGroupTimer,
- shareGroupMetrics
+ shareGroupMetrics,
+ config.getInt(ServerConfigs.FETCH_MAX_BYTES_CONFIG),
Review Comment:
DLQ request could be for a single offset or multiple (if batch REJECTs). So
one readCall could serve multiple offsets. Since we are reading user topic data
- there is no good default value, hence opting for server default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
