smjn commented on code in PR #22479:
URL: https://github.com/apache/kafka/pull/22479#discussion_r3366981087
##########
server/src/main/java/org/apache/kafka/server/share/dlq/ShareGroupDLQStateManager.java:
##########
@@ -231,6 +251,7 @@ public ProduceRequestHandler(
) {
this.param = param;
this.result = result;
+ this.originalRecordData = new ArrayList<>();
Review Comment:
Hi,
Yes, it is lazy. The actual records will only be fetched when the record
copy config is enabled and share group is configured correctly. Opted to create
empty ArrayList to prevent checking nulls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
