frankvicky commented on code in PR #22511: URL: https://github.com/apache/kafka/pull/22511#discussion_r3374735952
########## group-coordinator/group-coordinator-api/src/main/java/org/apache/kafka/coordinator/group/api/streams/StreamsGroupTopologyDescription.java: ########## @@ -0,0 +1,286 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group.api.streams; + +import java.util.Collection; +import java.util.List; +import java.util.Objects; +import java.util.Optional; +import java.util.Set; + +/** + * Broker-side description of a Kafka Streams topology, as pushed by clients via + * {@code StreamsGroupTopologyDescriptionUpdate} and consumed by + * {@link StreamsGroupTopologyDescriptionPlugin} implementations. + * + * <p>This type mirrors {@code org.apache.kafka.streams.TopologyDescription} in shape + * but lives in {@code group-coordinator-api} so plugin implementations do not need + * to depend on {@code kafka-streams}. The wire schema only carries the successor + * relation; plugins that need both directions reconstruct predecessors in a single + * pass over the nodes. + */ +public class StreamsGroupTopologyDescription { Review Comment: The class doesn't have `@InterfaceStability.Evolving` on the KIP. Not sure if we also want to add `@InterfaceStability.Evolving` here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
