frankvicky commented on code in PR #22511:
URL: https://github.com/apache/kafka/pull/22511#discussion_r3381081488
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -897,6 +905,16 @@ protected List<ShareGroupPartitionAssignor>
shareGroupAssignors(
return assignors;
}
+ public StreamsGroupTopologyDescriptionPlugin
streamsGroupTopologyDescriptionPlugin(
+ Map<String, ?> additionalConfigs
+ ) {
+ Map<String, Object> overrides = new HashMap<>(additionalConfigs);
+ return config.getConfiguredInstance(
+ STREAMS_GROUP_TOPOLOGY_DESCRIPTION_PLUGIN_CLASS_CONFIG,
+ StreamsGroupTopologyDescriptionPlugin.class,
+ overrides);
+ }
Review Comment:
updated the pr description.
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfigTest.java:
##########
@@ -821,6 +826,90 @@ public void testDLQTopicNamePrefixCustomValue() {
assertEquals("my-dlq-", config.errorsDLQTopicNamePrefix());
}
+ @Test
+ public void testStreamsGroupTopologyDescriptionPluginDefaultIsNull() {
+ GroupCoordinatorConfig config = createConfig(new HashMap<>());
+ assertNull(config.streamsGroupTopologyDescriptionPlugin(Map.of()));
+ }
Review Comment:
updated the pr description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
