apoorvmittal10 commented on code in PR #22502:
URL: https://github.com/apache/kafka/pull/22502#discussion_r3376477851
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -3346,7 +3382,7 @@ private boolean isDLQEnabledForGroup() {
* Phase 2: Enqueues to DLQ, then transitions ARCHIVING → ARCHIVED and
persists ARCHIVED to the persister
* This method handles the complete phase 2 flow.
*/
- void initiateDLQAndArchive(InFlightState updatedState, long firstOffset,
+ void initiateDLQAndArchive(Runnable archiveAction, long firstOffset,
Review Comment:
While the Runnable will work but don't you think that it confuses that there
might be another thread to run the call? Shouldn't we use Consumer<> functional
interface in this case?
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -453,6 +453,8 @@ public CompletableFuture<Void> maybeInitialize() {
.build()
).whenComplete((result, exception) -> {
Throwable throwable = null;
+ // Batches read from the persister in the ARCHIVING state whose
DLQ flow (phase 2) must be resumed.
+ List<DlqBatch> dlqBatches = new ArrayList<>();
Review Comment:
nit: initialize when needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
