smjn commented on code in PR #22502:
URL: https://github.com/apache/kafka/pull/22502#discussion_r3378578945
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -3346,7 +3382,7 @@ private boolean isDLQEnabledForGroup() {
* Phase 2: Enqueues to DLQ, then transitions ARCHIVING → ARCHIVED and
persists ARCHIVED to the persister
* This method handles the complete phase 2 flow.
*/
- void initiateDLQAndArchive(InFlightState updatedState, long firstOffset,
+ void initiateDLQAndArchive(Runnable archiveAction, long firstOffset,
Review Comment:
Yes correct,
But per java spec a function with no args and no return value is considered
`Runnable`. `Consumer` is for method with single arg and orthogonally
`Supplier` is no arg method which returns a value. In this context - `Runnable`
is technically the best option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
