smjn commented on code in PR #22479:
URL: https://github.com/apache/kafka/pull/22479#discussion_r3379851288
##########
server/src/main/java/org/apache/kafka/server/share/dlq/ShareGroupDLQStateManager.java:
##########
@@ -121,10 +134,16 @@ public ShareGroupDLQStateManager(
throw new IllegalArgumentException("ShareGroupMetrics must not be
null.");
}
+ if (logReader == null) {
+ throw new IllegalArgumentException("LogReader must not be null.");
+ }
+
this.time = time;
this.timer = timer;
this.cacheHelper = cacheHelper;
this.shareGroupMetrics = shareGroupMetrics;
+ this.maxFetchBytes = maxFetchBytes;
+ this.logReader = logReader;
Review Comment:
We'll keep best effort approach for now and a follow up PR for gathering
data from remote storage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
