chickenchickenlove commented on code in PR #22473:
URL: https://github.com/apache/kafka/pull/22473#discussion_r3380001179
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -4262,8 +4262,13 @@ private
CoordinatorResult<ConsumerGroupHeartbeatResponseData, CoordinatorRecord>
// We will write a member epoch of -2 for this departing static member.
// Assignment epochs are reset to 0 so when the static member rejoins,
partitions
// are considered assigned from epoch 0 to the new member ID.
+ MemberState nextState = member.state() ==
MemberState.UNREVOKED_PARTITIONS ?
+ MemberState.STABLE :
Review Comment:
@dajac
Thanks for your comments and this is very good point!
I've addressed it by using `CurrentAssignmentBuilder` to determine the next
state.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
