squah-confluent commented on code in PR #22473:
URL: https://github.com/apache/kafka/pull/22473#discussion_r3397349939
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -4259,11 +4259,27 @@ private
CoordinatorResult<ConsumerGroupHeartbeatResponseData, CoordinatorRecord>
ConsumerGroup group,
ConsumerGroupMember member
) {
+ ConsumerGroupMember reconciledMember = member;
+ if (member.state() == MemberState.UNREVOKED_PARTITIONS) {
+ reconciledMember = new CurrentAssignmentBuilder(member)
+ .withMetadataImage(metadataImage)
+ .withTargetAssignment(
+ group.assignmentEpoch(),
+ group.targetAssignment(member.memberId())
+ )
+
.withResolvedRegularExpressions(group.resolvedRegularExpressions())
+ .withCurrentPartitionEpoch(group::currentPartitionEpoch)
+ .withOwnedTopicPartitions(List.of())
+ .build();
+ }
+
Review Comment:
`maybeReconcile` cancels the rebalance timeout for the member when exiting
`UNREVOKED_PARTITIONS`. Do we need to do the same here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
