jsancio commented on code in PR #22505: URL: https://github.com/apache/kafka/pull/22505#discussion_r3387876038
########## raft/src/test/java/org/apache/kafka/raft/internals/ChangeVoterHandlerStateTest.java: ########## @@ -0,0 +1,437 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.raft.internals; + +import org.apache.kafka.common.Uuid; +import org.apache.kafka.common.message.AddRaftVoterResponseData; +import org.apache.kafka.common.message.RemoveRaftVoterResponseData; +import org.apache.kafka.common.metrics.KafkaMetric; +import org.apache.kafka.common.metrics.Metrics; +import org.apache.kafka.common.protocol.Errors; +import org.apache.kafka.common.utils.MockTime; +import org.apache.kafka.raft.Endpoints; +import org.apache.kafka.raft.ReplicaKey; + +import org.junit.jupiter.api.Test; + +import java.util.Optional; +import java.util.concurrent.CompletableFuture; + +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class ChangeVoterHandlerStateTest { + + private KafkaMetric getMetric(Metrics metrics, String name) { + return metrics.metrics().get(metrics.metricName(name, "raft-metrics")); + } + + @Test + public void testAddVoterLifecycle() { Review Comment: Because they store different information. Remove voter only needs to know the last offset and timeout while add voter needs to know the last offset, timer, voter key, voter endpoint, etc. One way to think about it is that ChangeVoterHandlerState is the pending state as a sum-type which can have 4 possible values empty, add voter state, remove voter state or update voter state (coming in the next PR). We can model it like I do in this PR or we can model it using a seal interface with 4 sum-types. Similar to EpochState. Is that what you are thinking? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
