ahuang98 commented on code in PR #22505:
URL: https://github.com/apache/kafka/pull/22505#discussion_r3391388435
##########
raft/src/main/java/org/apache/kafka/raft/internals/BlockingMessageQueue.java:
##########
@@ -17,41 +17,82 @@
package org.apache.kafka.raft.internals;
import org.apache.kafka.common.errors.InterruptException;
+import org.apache.kafka.raft.RaftMessage;
import org.apache.kafka.raft.RaftMessageQueue;
import java.util.Optional;
import java.util.concurrent.BlockingQueue;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.CompletionStage;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicInteger;
public class BlockingMessageQueue implements RaftMessageQueue {
- private final BlockingQueue<QueueEntry> queue = new
LinkedBlockingQueue<>();
+ // Marker object for wakeup events
+ private static final Object WAKEUP = new Object();
+
+ private final BlockingQueue<Object> queue = new LinkedBlockingQueue<>();
Review Comment:
I'm not sure if I prefer this over what you had originally, I was thinking
something like the following could work
```
sealed interface QueueEntry permits MessageEntry, WakeupEntry { }
final class MessageEntry implements QueueEntry {
private final CompletableFuture<RaftMessage> future = new
CompletableFuture<>();
private final RaftMessage message;
...
}
enum WakeupEntry implements QueueEntry {
INSTANCE
}
```
then the blockingMessageQueue would look like
```
private final BlockingQueue<QueueEntry> queue = new LinkedBlockingQueue<>();
public Optional<MessageEntry> poll(long timeoutMs) {
...
while (entry instanceof WakeupEntry) {
entry = queue.poll();
}
```
I know you want to rewrite/replace the message queue eventually, but this
seems lightweight enough to incorporate now, wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
