see-quick opened a new pull request, #22578:
URL: https://github.com/apache/kafka/pull/22578
Currently, passing additional Docker build arguments to ducker-ak requires
using sed to rewrite the script at runtime i.e.,:
```bash
${SED} -i "s|\${docker_args}|${ADDITIONAL_BUILD_ARGS}|"
tests/docker/ducker-ak
```
This is fragile (any rename in ducker-ak silently breaks it), mutates a
checked-in source file during CI, and requires a hardcoded list of supported
args that must be updated for every new build arg.
This PR adds native` --build-arg` support to ducker-ak, following the same
CLI > ENV > default pattern established by --memory (KAFKA-20378) and
--skip-build (KAFKA-20379). The same CI workflow becomes:
```bash
DOCKER_BUILD_ARGS="--build-arg BASE_IMAGE=base-image --build-arg
PYTHON_VERSION=3.11 --build-arg ANOTHER_ARG_NAME=another-arg-name"
./tests/docker/run_tests.sh
// or via ducker-ak up
./tests/docker/ducker-ak up --build-arg BASE_IMAGE=base-image --build-arg
PYTHON_VERSION=3.11 ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
