see-quick commented on code in PR #22578:
URL: https://github.com/apache/kafka/pull/22578#discussion_r3422940378
##########
tests/docker/ducker-ak:
##########
@@ -417,10 +423,12 @@ ducker_up() {
-c|--clean-build) set_once clean_build "true" "clean build";
shift;;
-m|--kafka_mode) set_once kafka_mode "${2}" "the mode in which
kafka will run"; shift 2;;
--memory) set_once docker_run_memory_limit "${2}" "the container
memory limit"; shift 2;;
+ --build-arg) verify_command_line_argument "${2}" "docker build
arg"; docker_args="${docker_args} --build-arg ${2}"; shift 2;;
--ipv6) set_once ipv6 "true" "enable IPv6"; shift;;
*) set_once image_name "${1}" "container image name"; shift;;
esac
done
+ [[ -n "${docker_args}" ]] || docker_args="${DOCKER_BUILD_ARGS:-}"
Review Comment:
I wonder how much beneficial would that be. Do you think that anybody will
combine both of those approaches (i.e., CLI and ENV)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
