lucasbru commented on code in PR #22213:
URL: https://github.com/apache/kafka/pull/22213#discussion_r3418981506
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2206,6 +2207,25 @@ private CoordinatorResult<StreamsGroupHeartbeatResult,
CoordinatorRecord> stream
)
));
+ String rackAwareTagsValue =
currentAssignmentConfigs.getOrDefault("rack.aware.assignment.tags", "");
Review Comment:
Just take into account that these are stored in the
StreamsGroupMetadataValue, and parsing then needs to happen on the replay path
(when the group metadata loads). So any unhandled parse error will prevent the
GC from starting. That's why we chose keeping this a simple string to string
copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
