gabriellefu commented on code in PR #22213:
URL: https://github.com/apache/kafka/pull/22213#discussion_r3429456390
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java:
##########
@@ -579,10 +581,20 @@ private void onSuccessResponse(final
StreamsGroupHeartbeatResponse response, fin
if (statuses != null) {
streamsRebalanceData.setStatuses(statuses);
if (!statuses.isEmpty()) {
- String statusDetails = statuses.stream()
- .map(status -> "(" + status.statusCode() + ") " +
status.statusDetail())
- .collect(Collectors.joining(", "));
- logger.warn("Membership is in the following statuses: {}",
statusDetails);
+ List<String> statusesToLog = new ArrayList<>();
+ for (StreamsGroupHeartbeatResponseData.Status status :
statuses) {
+ if (status.statusCode() ==
StreamsGroupHeartbeatResponse.Status.MISSING_CLIENT_TAGS.code()) {
+ if
(!status.statusDetail().equals(lastMissingClientTagsDetail)) {
+ lastMissingClientTagsDetail =
status.statusDetail();
Review Comment:
make sense, changed now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
