apoorvmittal10 commented on code in PR #22780:
URL: https://github.com/apache/kafka/pull/22780#discussion_r3546465903
##########
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##########
@@ -267,20 +311,63 @@ private void completeLocalLogShareFetchRequest() {
}
private void
processAcquiredTopicPartitionsForLocalLogFetch(LinkedHashMap<TopicIdPartition,
Long> topicPartitionData) {
- List<ShareFetchPartitionData> shareFetchPartitionDataList = new
ArrayList<>();
+ // If localPartitionsAlreadyFetched is empty hence the async fetch was
never attempted hence retry
+ // else try to complete the request.
+ CompletableFuture<LinkedHashMap<TopicIdPartition, LogReadResult>>
readFuture = null;
Review Comment:
Doesn't matter, done though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
