apoorvmittal10 commented on code in PR #22780:
URL: https://github.com/apache/kafka/pull/22780#discussion_r3546471186
##########
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##########
@@ -912,19 +1135,56 @@ private void completeRemoteStorageShareFetchRequest() {
shareFetch, shareFetchPartitionDataList, sharePartitions,
metadataProvider, exceptionHandler);
shareFetch.maybeComplete(remoteFetchResponse);
log.trace("Remote share fetch request completed successfully,
response: {}", remoteFetchResponse);
- } catch (InterruptedException | ExecutionException e) {
- log.error("Exception occurred in completing remote fetch {} for
delayed share fetch request {}", pendingRemoteFetchesOpt.get(), e);
-
handleExceptionInCompletingRemoteStorageShareFetchRequest(acquiredNonRemoteFetchTopicPartitionData.keySet(),
e);
} catch (Exception e) {
log.error("Unexpected error in processing delayed share fetch
request", e);
handleExceptionInCompletingRemoteStorageShareFetchRequest(acquiredNonRemoteFetchTopicPartitionData.keySet(),
e);
} finally {
+ // TODO: Check maybe to skip
acquiredNonRemoteFetchTopicPartitionData from releasing locks
Review Comment:
It was coming from old refactored metrhod where it existed hence didn't
clean it yet and kept for future. Anyways corrected and tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
