junrao commented on code in PR #22908:
URL: https://github.com/apache/kafka/pull/22908#discussion_r3632393403
##########
clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java:
##########
@@ -304,7 +304,7 @@ public static AbstractResponse parseResponse(ApiKeys
apiKey, Readable readable,
* quota violation, sends out responses before throttling.
*/
public boolean shouldClientThrottle(short version) {
- return false;
+ return
apiKey.messageType.responseSchemas()[version].get("throttle_time_ms") != null;
Review Comment:
Could we remove all the overrides that return `true` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
