junrao commented on code in PR #22908:
URL: https://github.com/apache/kafka/pull/22908#discussion_r3634519058
##########
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java:
##########
@@ -359,6 +359,30 @@ public void testSerialization() {
}
}
+ @Test
+ public void testClientThrottlesResponsesWithThrottleTime() {
Review Comment:
This test is ok, but it's not comprehensive. Could we test
shouldClientThrottle() on all versions of all ApiKeys? shouldClientThrottle()
should only be false if (1) the request version is pre KIP-219 (which we can
hardcode) or (2) the response doesn't contain the throttleTimeMs field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
