gaurav-narula commented on code in PR #22943:
URL: https://github.com/apache/kafka/pull/22943#discussion_r3661187645
##########
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##########
@@ -454,7 +454,7 @@ public void registerFailure() throws Exception {
public void testCloseOldestConnection() throws Exception {
String id = "0";
selector.connect(id, new InetSocketAddress("localhost", server.port),
BUFFER_SIZE, BUFFER_SIZE);
- NetworkTestUtils.waitForChannelConnected(selector, id);
+ NetworkTestUtils.waitForChannelReady(selector, id);
Review Comment:
Reading `SslTransportLayer#ready()`, it would return `true` if `state ==
State.POST_HANDSHAKE || state == State.READY`.
Could there be a race on `state == POST_HANDSHAKE` and the next poll
processing the post handshake messages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
