lh0156 commented on PR #22943: URL: https://github.com/apache/kafka/pull/22943#issuecomment-5159309029
Follow-up on the TLS 1.3 post-handshake question: I rechecked the selector ordering. During `pollSelectionKeys`, the idle-expiry timestamp is refreshed before the channel read/processing; `maybeCloseOldestConnection` runs after the selected keys have been processed. Therefore, if a pending TLS 1.3 post-handshake message makes the key readable, it refreshes the connection before the expiry check. The test also waits for TCP connectivity before protocol readiness, so the idle interval starts only after the initial connection has been processed. The targeted selector suites and full `:clients:test` passed. No production change is needed for this test scenario. @gaurav-narula, please re-review when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
