Parkerhiphop commented on code in PR #22932:
URL: https://github.com/apache/kafka/pull/22932#discussion_r3694614495
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -253,10 +250,10 @@ public Optional<String> serverConfigName(String
configName) {
TopicConfig.LOCAL_LOG_RETENTION_MS_DOC)
.define(TopicConfig.LOCAL_LOG_RETENTION_BYTES_CONFIG, LONG,
DEFAULT_LOCAL_RETENTION_BYTES, atLeast(-2), MEDIUM,
TopicConfig.LOCAL_LOG_RETENTION_BYTES_DOC)
- .define(TopicConfig.REMOTE_LOG_COPY_DISABLE_CONFIG, BOOLEAN,
false, MEDIUM, TopicConfig.REMOTE_LOG_COPY_DISABLE_DOC)
+ .define(TopicConfig.REMOTE_LOG_COPY_DISABLE_CONFIG, BOOLEAN,
DEFAULT_REMOTE_LOG_COPY_DISABLE, MEDIUM,
TopicConfig.REMOTE_LOG_COPY_DISABLE_DOC)
.define(TopicConfig.REMOTE_COPY_LAG_MS_CONFIG, LONG,
RemoteLogManagerConfig.DEFAULT_LOG_REMOTE_COPY_LAG_MS,
atLeast(RemoteLogManagerConfig.MAX_LOG_REMOTE_COPY_LAG_MS), MEDIUM,
TopicConfig.REMOTE_COPY_LAG_MS_DOC)
.define(TopicConfig.REMOTE_COPY_LAG_BYTES_CONFIG, LONG,
RemoteLogManagerConfig.DEFAULT_LOG_REMOTE_COPY_LAG_BYTES,
atLeast(RemoteLogManagerConfig.MAX_LOG_REMOTE_COPY_LAG_BYTES), MEDIUM,
TopicConfig.REMOTE_COPY_LAG_BYTES_DOC)
- .define(TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_CONFIG,
BOOLEAN, false, MEDIUM, TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_DOC)
+ .define(TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_CONFIG,
BOOLEAN, DEFAULT_REMOTE_LOG_DELETE_ON_DISABLE, MEDIUM,
TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_DOC)
.define(TopicConfig.ERRORS_DEADLETTERQUEUE_GROUP_ENABLE_CONFIG, BOOLEAN, false,
MEDIUM, TopicConfig.ERRORS_DEADLETTERQUEUE_GROUP_ENABLE_DOC)
Review Comment:
Yes. I checked the boolean config definitions in LogConfig and added
DEFAULT_ERRORS_DEADLETTERQUEUE_GROUP_ENABLE so the remaining literal false
default uses a named constant for consistency.
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -253,10 +250,10 @@ public Optional<String> serverConfigName(String
configName) {
TopicConfig.LOCAL_LOG_RETENTION_MS_DOC)
.define(TopicConfig.LOCAL_LOG_RETENTION_BYTES_CONFIG, LONG,
DEFAULT_LOCAL_RETENTION_BYTES, atLeast(-2), MEDIUM,
TopicConfig.LOCAL_LOG_RETENTION_BYTES_DOC)
- .define(TopicConfig.REMOTE_LOG_COPY_DISABLE_CONFIG, BOOLEAN,
false, MEDIUM, TopicConfig.REMOTE_LOG_COPY_DISABLE_DOC)
+ .define(TopicConfig.REMOTE_LOG_COPY_DISABLE_CONFIG, BOOLEAN,
DEFAULT_REMOTE_LOG_COPY_DISABLE, MEDIUM,
TopicConfig.REMOTE_LOG_COPY_DISABLE_DOC)
.define(TopicConfig.REMOTE_COPY_LAG_MS_CONFIG, LONG,
RemoteLogManagerConfig.DEFAULT_LOG_REMOTE_COPY_LAG_MS,
atLeast(RemoteLogManagerConfig.MAX_LOG_REMOTE_COPY_LAG_MS), MEDIUM,
TopicConfig.REMOTE_COPY_LAG_MS_DOC)
.define(TopicConfig.REMOTE_COPY_LAG_BYTES_CONFIG, LONG,
RemoteLogManagerConfig.DEFAULT_LOG_REMOTE_COPY_LAG_BYTES,
atLeast(RemoteLogManagerConfig.MAX_LOG_REMOTE_COPY_LAG_BYTES), MEDIUM,
TopicConfig.REMOTE_COPY_LAG_BYTES_DOC)
- .define(TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_CONFIG,
BOOLEAN, false, MEDIUM, TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_DOC)
+ .define(TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_CONFIG,
BOOLEAN, DEFAULT_REMOTE_LOG_DELETE_ON_DISABLE, MEDIUM,
TopicConfig.REMOTE_LOG_DELETE_ON_DISABLE_DOC)
.define(TopicConfig.ERRORS_DEADLETTERQUEUE_GROUP_ENABLE_CONFIG, BOOLEAN, false,
MEDIUM, TopicConfig.ERRORS_DEADLETTERQUEUE_GROUP_ENABLE_DOC)
Review Comment:
Yes. I checked the boolean config definitions in LogConfig and added
`DEFAULT_ERRORS_DEADLETTERQUEUE_GROUP_ENABLE` so the remaining literal false
default uses a named constant for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
