UladzislauBlok commented on PR #22778: URL: https://github.com/apache/kafka/pull/22778#issuecomment-5158101924
@mjsax Thanks for the review! Addressed all the open comments. Re: KIP-1071 itself I wasn't able to find any "hard" mention of exposing metadata per node rather than per member (only in the RPC description). I think exposing information per member fits the protocol design well since each stream thread is an independent member, so IMO it's totally fine to merge it on the client side. The only potential issue I can think of is if this info ends up being needed elsewhere later, which would force us to fix it on the broker anyway. Though I don't think that's a real concern here since this metadata is specifically built for Kafka Streams IQ. WDYT? Should we clarify this point in the KIP then to be explicit about this case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
