aliehsaeedii commented on PR #22778: URL: https://github.com/apache/kafka/pull/22778#issuecomment-5342820638
> Thanks. I am not sure TBH -- I agree that the KIP is not very detailed about it... But in the "classic" protocol, it's also encoded per node. Both "classic" and "streams" are "member based", but IQ itself is "client based"; all threads within a client share the same IQ endpoint. > > It's a minor thing overall... And it seems we could also only change with 4.5 release (no need to rush into 4.4), what gives us more time to discuss. Would love to hear from others about this question (\cc @lucasbru @bbejeck @aliehsaeedii) Agree we should keep the broker per-member and just union client-side (as this PR does) — the client has to be robust against already-released brokers regardless, so a per-node broker change buys no correctness and only saves a repeated endpoint on the wire; +1 to declaring per-member the spec, which #23080 already documents. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
