[
https://issues.apache.org/jira/browse/KAFKA-20679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101122#comment-18101122
]
Yunseop Eom commented on KAFKA-20679:
-------------------------------------
Opened PR #23031 for KAFKA-20679: https://github.com/apache/kafka/pull/23031
The change removes the deprecated Yammer-based group coordinator metrics
scheduled for Kafka 5.0 removal under KIP-1301. GroupCoordinatorMetrics now
uses Kafka Metrics only; the broker, benchmark, tests, test utilities, and
monitoring documentation were updated accordingly.
TDD verification:
- RED: a baseline test asserting that deprecated Yammer metrics are absent
failed because the old gauges were registered.
- GREEN: the implementation removed the registration and cleanup paths, and the
Kafka Metrics assertions pass.
Verification completed:
- :group-coordinator:test targeted metrics tests passed.
- Full :group-coordinator:test passed.
- :core:compileScala passed.
- :jmh-benchmarks:compileJava passed.
- Checkstyle, SpotBugs, and git diff --check passed.
The PR is open for maintainer review.
> Remove deprecated Yammer-based group coordinator metrics
> --------------------------------------------------------
>
> Key: KAFKA-20679
> URL: https://issues.apache.org/jira/browse/KAFKA-20679
> Project: Kafka
> Issue Type: Improvement
> Components: group-coordinator, metrics
> Reporter: Nick Guo
> Assignee: Nick Guo
> Priority: Blocker
> Fix For: 5.0.0
>
>
> [KIP-1301|https://cwiki.apache.org/confluence/x/Z5U8G] deprecated several
> Yammer-based group coordinator metrics in Kafka 4.4 and introduced equivalent
> Kafka Metrics replacements. This issue tracks removing the deprecated Yammer
> metrics in Kafka 5.0.
> Deprecated metrics to remove:
> * kafka.coordinator.group:type=GroupMetadataManager,name=NumGroups
> * kafka.coordinator.group:type=GroupMetadataManager,name=NumOffsets
> *
> kafka.coordinator.group:type=GroupMetadataManager,name=NumGroupsPreparingRebalance
> *
> kafka.coordinator.group:type=GroupMetadataManager,name=NumGroupsCompletingRebalance
> * kafka.coordinator.group:type=GroupMetadataManager,name=NumGroupsStable
> * kafka.coordinator.group:type=GroupMetadataManager,name=NumGroupsDead
> * kafka.coordinator.group:type=GroupMetadataManager,name=NumGroupsEmpty
> Replacement Kafka Metrics:
> *
> kafka.server:type=group-coordinator-metrics,name=group-count,protocol=classic
> * kafka.server:type=group-coordinator-metrics,name=offset-count
> *
> kafka.server:type=group-coordinator-metrics,name=classic-group-count,state=\{PreparingRebalance|CompletingRebalance|Stable|Dead|Empty}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
