[
https://issues.apache.org/jira/browse/KAFKA-16635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18101155#comment-18101155
]
Yunseop Eom commented on KAFKA-16635:
-------------------------------------
PR opened: https://github.com/apache/kafka/pull/23042
Investigated the flaky failure where replication completed in 2203 ms, below
the fixed 3600 ms lower bound. The test was using elapsed time as a proxy for
quota enforcement, although the first fetch may exceed the configured rate
before the rolling quota sensor has a complete sample.
The PR removes that fragile lower-bound assertion, keeps a generous upper bound
for unexpectedly slow replication, and verifies the measured leader replication
byte rate remains within the established tolerance range. This directly tests
quota enforcement while allowing the documented initial burst.
Validation:
- Full ReplicationQuotasTest: passed
- Targeted shouldThrottleOldSegments test: passed
- 5 baseline repetitions before the change: all passed
- Spotless and Checkstyle: passed
- git diff --check: passed
Status: PR is open and awaiting review.
> Flaky test "shouldThrottleOldSegments(String).quorum=kraft" –
> kafka.server.ReplicationQuotasTest
> ------------------------------------------------------------------------------------------------
>
> Key: KAFKA-16635
> URL: https://issues.apache.org/jira/browse/KAFKA-16635
> Project: Kafka
> Issue Type: Test
> Reporter: Igor Soarez
> Priority: Major
> Labels: flaky-test
>
> "shouldThrottleOldSegments(String).quorum=kraft" –
> kafka.server.ReplicationQuotasTest
> {code:java}
> org.opentest4j.AssertionFailedError: Throttled replication of 2203ms should
> be > 3600.0ms ==> expected: <true> but was: <false> at
> app//org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
> at
> app//org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
> at app//org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
> at app//org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
> at app//org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:214)
> at
> app//kafka.server.ReplicationQuotasTest.shouldThrottleOldSegments(ReplicationQuotasTest.scala:260)
> {code}
> https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15816/1/tests/
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
