lh0156 opened a new pull request, #23043:
URL: https://github.com/apache/kafka/pull/23043

   Closes KAFKA-18584
   
   ### Summary
   
   - Exercise `testControllerRestart` under both isolated and combined KRaft 
modes.
   - Keep the shared Raft manager alive while the broker still owns it during a 
combined-mode controller restart.
   
   In combined mode, `ControllerServer.shutdown()` previously shut down the 
shared Raft manager even though the broker continued using it. Restarting the 
controller could then observe a null manager and fail with the NPE reported in 
KAFKA-18584. The lifecycle guard preserves the manager until the broker 
releases it.
   
   ### Tests
   
   - `./gradlew :test-common:test-common-runtime:test --tests 
org.apache.kafka.common.test.junit.ClusterTestExtensionsTest --no-build-cache 
--console=plain`
   - `./gradlew :core:spotlessCheck 
:test-common:test-common-runtime:spotlessCheck --no-build-cache --console=plain`
   - `./gradlew :core:checkstyleMain 
:test-common:test-common-runtime:checkstyleTest --no-build-cache 
--console=plain`
   
   The targeted regression test passed three fresh reruns for both KRaft modes, 
and the full `ClusterTestExtensionsTest` passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to