mjsax commented on code in PR #23009:
URL: https://github.com/apache/kafka/pull/23009#discussion_r3707906932
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/TaskMetrics.java:
##########
@@ -250,7 +250,7 @@ public static Sensor recordLatenessSensor(final String
threadId,
public static Sensor droppedRecordsSensor(final String threadId,
final String taskId,
final StreamsMetricsImpl
streamsMetrics) {
- return invocationRateAndTotalSensor(
+ return rateAndTotalSensor(
Review Comment:
Oh. So this metric (`dropped-records-rate`) is actually broken for
`InMemoryWindowStore` and `InMemorySessionStore`, too. Great catch.
Guess we just need to update the Jira and PR description, as this PR does
fix the issue, too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
