aliehsaeedii commented on code in PR #23009:
URL: https://github.com/apache/kafka/pull/23009#discussion_r3726467254
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java:
##########
@@ -254,7 +254,7 @@ public void put(final Bytes key,
final long segmentId = segments.segmentId(timestamp);
final S segment = segments.getOrCreateSegmentIfLive(segmentId,
internalProcessorContext, observedStreamTime);
if (segment == null) {
- expiredRecordSensor.record(1.0d,
internalProcessorContext.currentSystemTimeMs());
+ expiredRecordSensor.record();
Review Comment:
This is the only expired-record drop that logs nothing — the sibling in
`AbstractDualSchemaRocksDBSegmentedBytesStore` follows the same `record()` with
`LOG.warn("Skipping record for expired segment.")`. Worth adding here.
##########
streams/src/test/java/org/apache/kafka/streams/state/internals/InMemorySessionStoreTest.java:
##########
@@ -318,4 +323,44 @@ private InMemorySessionStore
openTransactionalSessionStore() {
return store;
}
+
Review Comment:
I know this is only a test class but do we need this blank line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
