adikou commented on PR #22271: URL: https://github.com/apache/kafka/pull/22271#issuecomment-5185862592
@chia7712 Hope I've addressed any outstanding concerns in this PR. Only task left is the follow-up https://issues.apache.org/jira/browse/KAFKA-20684 before code freeze. Related but not blocking: I've put out https://cwiki.apache.org/confluence/spaces/KAFKA/pages/440304999/KIP-1369+API-Contract+Annotations+for+Nullity+Thread+Safety for the lock guards that could've caught the earlier bug. Icymi. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
