adikou commented on code in PR #22271:
URL: https://github.com/apache/kafka/pull/22271#discussion_r3724733859
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -2241,8 +2253,9 @@ private void release() {
currentThread.set(NO_CURRENT_THREAD);
}
- private void subscribeInternal(Pattern pattern,
Optional<ConsumerRebalanceListener> listener) {
+ private void subscribeInternal(Pattern pattern, ConsumerRebalanceListener
listener) {
acquireAndEnsureOpen();
+ subscriptions.setRebalanceListener(listener, this);
Review Comment:
Actually! This _one_ particular line was a miss. Thanks for the catch
@lianetm !
The others have a listener != null check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
