dajac commented on code in PR #22969: URL: https://github.com/apache/kafka/pull/22969#discussion_r3734578599
########## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java: ########## Review Comment: I wonder whether we should also change this. The assumption is kind of wrong as in-mem changes could have been made so reverting is not alway correct. Should we just free to batch if the batch is empty? My concern is that we have many other paths calling `flushCurrentBatch()` so I am not sure whether gating the flush in `append` in enough to cover all the possible cases. It is good to have it for sure but it may not be enough. @squah-confluent @dongnuo123 What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
