chia7712 commented on code in PR #22969: URL: https://github.com/apache/kafka/pull/22969#discussion_r3824288861
########## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java: ########## Review Comment: > The non-atomic flush later in the method will never do it because hasRoomFor returns true when the batch is empty I prefer to add an explicit condition rather than counting on the "internal" behavior. It is more consistent too :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
