apoorvmittal10 commented on PR #23094: URL: https://github.com/apache/kafka/pull/23094#issuecomment-5241279829
> Fix a bug in `ClientMetricsManager.processPushTelemetryRequest()` where the `terminating` flag is unconditionally set in the `finally` block, even when request validation fails. > > When a client sends a `PushTelemetry` request with `terminating=true` but the request fails validation (e.g., stale `subscriptionId` → `UNKNOWN_SUBSCRIPTION_ID`), the client instance is permanently marked as terminating. All subsequent requests from that client are rejected with `INVALID_REQUEST`, making recovery impossible without creating a new client instance. > > Reviewers: Chia-Ping Tsai [[email protected]](mailto:[email protected]) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
